[Feature] - 마이페이지 좋아요 탭 및 검색 창 국가 탭 기능 구현 #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit 9c38e9c. |
jinyoung234
approved these changes
Oct 22, 2024
| export const BoxButton = styled.button` | ||
| display: flex; | ||
| gap: ${(props) => props.theme.spacing.m}; | ||
| justify-content: flex-start; |
There was a problem hiding this comment.
justify-content의 기본값이 flex-start라서 그런거 같네요~!
| @@ -26,6 +26,7 @@ export const QUERY_KEYS_MAP = { | |||
| selectedSortingOption, | |||
| selectedTravelPeriodOption, | |||
| ], | |||
| likes: () => [...QUERY_KEYS_MAP.travelogue.all, "likes"], | |||
There was a problem hiding this comment.
이 친구는 메서드로 만든 이유가 있을까요? 제가 보기엔 값으로 만들어도 충분하다는 생각이어서요!
There was a problem hiding this comment.
다른 부분들이 이러한 방식으로 구성되어 있어서 일관성을 위해서 해당 방식을 적용했습니다
| @@ -44,6 +44,15 @@ export interface MyTravelogue { | |||
| createdAt: string; | |||
| } | |||
|
|
|||
| export interface MyLikes { | |||
There was a problem hiding this comment.
여행기에 대한 타입인데, MyLikes라는 네이밍이 살짝 어색한 감이 있다고 생각하는데 시모는 어떻게 생각하실까요?!
Like 정도로만 해도 충분하다는 생각에 제안드려봅니다!
0jenn0
approved these changes
Oct 22, 2024
| export const BoxButton = styled.button` | ||
| display: flex; | ||
| gap: ${(props) => props.theme.spacing.m}; | ||
| justify-content: flex-start; |
There was a problem hiding this comment.
justify-content의 기본값이 flex-start라서 그런거 같네요~!
0jenn0
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
🙈 참고 사항
현재 검색 창에서 존재하지 않는 국가를 검색하고 국가 탭을 누르면 오류를 던지는 상황이 발생합니다. 이를 백엔드 측과 논의한 끝에 다른 탭과 동일하게 없는 경우에도 그대로 없는 데이터를 던지도록 상호 합의 하였습니다 그래서 작동시 오류가 뜰 수 있는 점 감안해주시면 감사하겠습니다